root/trunk/batman-adv-kernelland/device.c @ 1543

Revision 1543, 8.4 kB (checked in by marek, 8 months ago)

batman-adv: don't lock while sending packets

As in other parts of batman-adv, we should not lock while sending a packet but
keep the locked time as short as possible. Additionally, we should check
whether the interface is active, otherwise batman_if->net_dev might not be
available ...

Signed-off-by: Simon Wunderlich <siwu@…>
Acked-by: Marek Lindner <lindner_marek@…>

Line 
1/*
2 * Copyright (C) 2007-2009 B.A.T.M.A.N. contributors:
3 *
4 * Marek Lindner
5 *
6 * This program is free software; you can redistribute it and/or
7 * modify it under the terms of version 2 of the GNU General Public
8 * License as published by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License
16 * along with this program; if not, write to the Free Software
17 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
18 * 02110-1301, USA
19 *
20 */
21
22#include <linux/device.h>
23#include "main.h"
24#include "device.h"
25#include "send.h"
26#include "types.h"
27#include "hash.h"
28#include "hard-interface.h"
29
30#include "compat.h"
31
32static struct class *batman_class;
33
34static int Major;       /* Major number assigned to our device driver */
35
36static const struct file_operations fops = {
37        .open = bat_device_open,
38        .release = bat_device_release,
39        .read = bat_device_read,
40        .write = bat_device_write,
41        .poll = bat_device_poll,
42};
43
44static struct device_client *device_client_hash[256];
45
46void bat_device_init(void)
47{
48        int i;
49
50        for (i = 0; i < 256; i++)
51                device_client_hash[i] = NULL;
52}
53
54int bat_device_setup(void)
55{
56        int tmp_major;
57
58        if (Major)
59                return 1;
60
61        /* register our device - kernel assigns a free major number */
62        tmp_major = register_chrdev(0, DRIVER_DEVICE, &fops);
63        if (tmp_major < 0) {
64                printk(KERN_ERR "batman-adv:Registering the character device failed with %d\n",
65                          tmp_major);
66                return 0;
67        }
68
69        batman_class = class_create(THIS_MODULE, "batman-adv");
70
71        if (IS_ERR(batman_class)) {
72                printk(KERN_ERR "batman-adv:Could not register class 'batman-adv' \n");
73                return 0;
74        }
75
76        device_create(batman_class, NULL, MKDEV(tmp_major, 0), NULL,
77                      "batman-adv");
78
79        Major = tmp_major;
80        return 1;
81}
82
83void bat_device_destroy(void)
84{
85        if (!Major)
86                return;
87
88        device_destroy(batman_class, MKDEV(Major, 0));
89        class_destroy(batman_class);
90
91        /* Unregister the device */
92        unregister_chrdev(Major, DRIVER_DEVICE);
93
94        Major = 0;
95}
96
97int bat_device_open(struct inode *inode, struct file *file)
98{
99        unsigned int i;
100        struct device_client *device_client;
101
102        device_client = kmalloc(sizeof(struct device_client), GFP_KERNEL);
103
104        if (!device_client)
105                return -ENOMEM;
106
107        for (i = 0; i < 256; i++) {
108                if (!device_client_hash[i]) {
109                        device_client_hash[i] = device_client;
110                        break;
111                }
112        }
113
114        if (device_client_hash[i] != device_client) {
115                printk(KERN_ERR "batman-adv:Error - can't add another packet client: maximum number of clients reached \n");
116                kfree(device_client);
117                return -EXFULL;
118        }
119
120        INIT_LIST_HEAD(&device_client->queue_list);
121        device_client->queue_len = 0;
122        device_client->index = i;
123        device_client->lock = __SPIN_LOCK_UNLOCKED(device_client->lock);
124        init_waitqueue_head(&device_client->queue_wait);
125
126        file->private_data = device_client;
127
128        inc_module_count();
129        return 0;
130}
131
132int bat_device_release(struct inode *inode, struct file *file)
133{
134        struct device_client *device_client =
135                (struct device_client *)file->private_data;
136        struct device_packet *device_packet;
137        struct list_head *list_pos, *list_pos_tmp;
138        unsigned long flags;
139
140        spin_lock_irqsave(&device_client->lock, flags);
141
142        /* for all packets in the queue ... */
143        list_for_each_safe(list_pos, list_pos_tmp, &device_client->queue_list) {
144                device_packet = list_entry(list_pos,
145                                           struct device_packet, list);
146
147                list_del(list_pos);
148                kfree(device_packet);
149        }
150
151        device_client_hash[device_client->index] = NULL;
152        spin_unlock_irqrestore(&device_client->lock, flags);
153
154        kfree(device_client);
155        dec_module_count();
156
157        return 0;
158}
159
160ssize_t bat_device_read(struct file *file, char __user *buf, size_t count,
161                        loff_t *ppos)
162{
163        struct device_client *device_client =
164                (struct device_client *)file->private_data;
165        struct device_packet *device_packet;
166        int error;
167        unsigned long flags;
168
169        if ((file->f_flags & O_NONBLOCK) && (device_client->queue_len == 0))
170                return -EAGAIN;
171
172        if ((!buf) || (count < sizeof(struct icmp_packet)))
173                return -EINVAL;
174
175        if (!access_ok(VERIFY_WRITE, buf, count))
176                return -EFAULT;
177
178        error = wait_event_interruptible(device_client->queue_wait,
179                                         device_client->queue_len);
180
181        if (error)
182                return error;
183
184        spin_lock_irqsave(&device_client->lock, flags);
185
186        device_packet = list_first_entry(&device_client->queue_list,
187                                         struct device_packet, list);
188        list_del(&device_packet->list);
189        device_client->queue_len--;
190
191        spin_unlock_irqrestore(&device_client->lock, flags);
192
193        error = __copy_to_user(buf, &device_packet->icmp_packet,
194                               sizeof(struct icmp_packet));
195
196        kfree(device_packet);
197
198        if (error)
199                return error;
200
201        return sizeof(struct icmp_packet);
202}
203
204ssize_t bat_device_write(struct file *file, const char __user *buff,
205                         size_t len, loff_t *off)
206{
207        struct device_client *device_client =
208                (struct device_client *)file->private_data;
209        struct icmp_packet icmp_packet;
210        struct orig_node *orig_node;
211        struct batman_if *batman_if;
212        uint8_t dstaddr[ETH_ALEN];
213        unsigned long flags;
214
215        if (len < sizeof(struct icmp_packet)) {
216                bat_dbg(DBG_BATMAN, "batman-adv:Error - can't send packet from char device: invalid packet size\n");
217                return -EINVAL;
218        }
219
220        if (!access_ok(VERIFY_READ, buff, sizeof(struct icmp_packet)))
221                return -EFAULT;
222
223        if (__copy_from_user(&icmp_packet, buff, sizeof(icmp_packet)))
224                return -EFAULT;
225
226        if (icmp_packet.packet_type != BAT_ICMP) {
227                bat_dbg(DBG_BATMAN, "batman-adv:Error - can't send packet from char device: got bogus packet type (expected: BAT_ICMP)\n");
228                return -EINVAL;
229        }
230
231        if (icmp_packet.msg_type != ECHO_REQUEST) {
232                bat_dbg(DBG_BATMAN, "batman-adv:Error - can't send packet from char device: got bogus message type (expected: ECHO_REQUEST)\n");
233                return -EINVAL;
234        }
235
236        icmp_packet.uid = device_client->index;
237
238        if (icmp_packet.version != COMPAT_VERSION) {
239                icmp_packet.msg_type = PARAMETER_PROBLEM;
240                icmp_packet.ttl = COMPAT_VERSION;
241                bat_device_add_packet(device_client, &icmp_packet);
242                goto out;
243        }
244
245        if (atomic_read(&module_state) != MODULE_ACTIVE)
246                goto dst_unreach;
247
248        spin_lock_irqsave(&orig_hash_lock, flags);
249        orig_node = ((struct orig_node *)hash_find(orig_hash, icmp_packet.dst));
250
251        if (!orig_node)
252                goto unlock;
253
254        if (!orig_node->router)
255                goto unlock;
256
257        batman_if = orig_node->batman_if;
258        memcpy(dstaddr, orig_node->router->addr, ETH_ALEN);
259
260        spin_unlock_irqrestore(&orig_hash_lock, flags);
261
262        if (!batman_if)
263                goto dst_unreach;
264
265        if (batman_if->if_active != IF_ACTIVE)
266                goto dst_unreach;
267
268        memcpy(icmp_packet.orig,
269               batman_if->net_dev->dev_addr,
270               ETH_ALEN);
271
272        send_raw_packet((unsigned char *)&icmp_packet,
273                        sizeof(struct icmp_packet),
274                        batman_if, dstaddr);
275
276        goto out;
277
278unlock:
279        spin_unlock_irqrestore(&orig_hash_lock, flags);
280dst_unreach:
281        icmp_packet.msg_type = DESTINATION_UNREACHABLE;
282        bat_device_add_packet(device_client, &icmp_packet);
283out:
284        return len;
285}
286
287unsigned int bat_device_poll(struct file *file, poll_table *wait)
288{
289        struct device_client *device_client =
290                (struct device_client *)file->private_data;
291
292        poll_wait(file, &device_client->queue_wait, wait);
293
294        if (device_client->queue_len > 0)
295                return POLLIN | POLLRDNORM;
296
297        return 0;
298}
299
300void bat_device_add_packet(struct device_client *device_client,
301                           struct icmp_packet *icmp_packet)
302{
303        struct device_packet *device_packet;
304        unsigned long flags;
305
306        device_packet = kmalloc(sizeof(struct device_packet), GFP_KERNEL);
307
308        if (!device_packet)
309                return;
310
311        INIT_LIST_HEAD(&device_packet->list);
312        memcpy(&device_packet->icmp_packet, icmp_packet,
313               sizeof(struct icmp_packet));
314
315        spin_lock_irqsave(&device_client->lock, flags);
316
317        /* while waiting for the lock the device_client could have been
318         * deleted */
319        if (!device_client_hash[icmp_packet->uid]) {
320                spin_unlock_irqrestore(&device_client->lock, flags);
321                kfree(device_packet);
322                return;
323        }
324
325        list_add_tail(&device_packet->list, &device_client->queue_list);
326        device_client->queue_len++;
327
328        if (device_client->queue_len > 100) {
329                device_packet = list_first_entry(&device_client->queue_list,
330                                                 struct device_packet, list);
331
332                list_del(&device_packet->list);
333                kfree(device_packet);
334                device_client->queue_len--;
335        }
336
337        spin_unlock_irqrestore(&device_client->lock, flags);
338
339        wake_up(&device_client->queue_wait);
340}
341
342void bat_device_receive_packet(struct icmp_packet *icmp_packet)
343{
344        struct device_client *hash = device_client_hash[icmp_packet->uid];
345
346        if (hash)
347                bat_device_add_packet(hash, icmp_packet);
348}
Note: See TracBrowser for help on using the browser.